fix: Prevent infinite buffering at the start of looped video on edge #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if the problem is by the time the callback is called the video element has resolved the seek and |
misteroneill
approved these changes
Jan 30, 2019
|
Perhaps we should consider either reverting #161 and only react to seek events or very clearly document the instances where the event is unreliable. |
|
I think the middleware approach makes more sense. Maybe it just needs to be documented somewhere that a seek with looping video will not go through middleware? |
forbesjo
approved these changes
Feb 21, 2019
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now Edge will sometimes buffer indefinitely once a video that is set to loop moves back to
currentTime0.After investigating this it appears that Edge does not set
tech.seeking()totrueduring aseekingevent for looping back tocurrentTime0. Normalseekingevents do settech.seeking()to true, as expected.Solution
I don't think that we need the extra check for
seekingon thetechat the start of the if statement. If we just had aseekingevent it should be fairly evident that we are seeking. I also think that the other two checks (for currentTime, and loop) should be enough to have this only happen when a video is looping.